[ci] Split tox jobs into CircleCI configuration #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wo0dyn
force-pushed
the
split-tox-jobs-in-circleci
branch
from
bc34925 to
30f0260
Compare
wo0dyn
force-pushed
the
split-tox-jobs-in-circleci
branch
2 times, most recently
from
1e34603 to
5c826ed
Compare
|
|
wo0dyn
force-pushed
the
split-tox-jobs-in-circleci
branch
from
5c826ed to
987102a
Compare
I've split CircleCI jobs into: * tox -e $(tox -l | grep django18 | tr '\n' ',') * tox -e $(tox -l | grep django19 | tr '\n' ',') * tox -e flake8 * tox -e isort-check This way, we can spot more quickly which jobs have failed, without reading the full log of the previous job.
wo0dyn
force-pushed
the
split-tox-jobs-in-circleci
branch
from
987102a to
8aa2cec
Compare
|
do we really want to separate django 1.8 and django 1.9 ? |
Yeah, that was intend to quickly spot which check failed. Since some features are deprecated in Django version, I think it's useful to detect which version of Django raises an potential issue, without digging the whole log. Besides, I feel:
more readable than
Overall, it doesn't take much time anyway. Still not convinced? 😉 |
mgu
approved these changes
Feb 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
I've split CircleCI jobs into:
tox -e $(tox -l | grep django18 | tr '\n' ',')tox -e $(tox -l | grep django19 | tr '\n' ',')tox -e flake8tox -e isort-checkThis way, we can spot more quickly which jobs have failed, without reading the full log of the previous job.