Skip form validation rules if a field is empty #191
Conversation
formidable/forms/__init__.py
Outdated
| super(BaseDynamicForm, self).__init__(*args, **kwargs) | ||
| self._bound_fields_cache = FormidableBoundFieldCache() | ||
|
|
||
| def rule_has_empty_fields(self, rule, data): |
There was a problem hiding this comment.
Why not put this kind of check in the rule itself ? Maybe for specific needed the rules can override its method in order to configure a specific check.
There was a problem hiding this comment.
sometimes you don't want the rule to be aware of the form/fields and sometimes you want :)
I can move that code in the Presets class but it will change the run method signature
There was a problem hiding this comment.
You are right. Sorry.
(I had a previous implementation in mind...)
formidable/forms/__init__.py
Outdated
| return any(( | ||
| is_empty_value(data.get(name, None)) | ||
| for name in used_fields | ||
| )) |
There was a problem hiding this comment.
Nitpick: you don't need double-parenthesis here 😉
return any(
is_empty_value(data.get(name, None))
for name in used_fields
)
| formidable = TestPresets.to_formidable(label='presets') | ||
| form_class = formidable.get_django_form_class(role='jedi') | ||
| form = form_class(data={'left': '', 'right': ''}) | ||
| self.assertFalse(form.is_valid(), form.errors) |
There was a problem hiding this comment.
I don't understand the test ... The field are required so the form validation will be false.
I would like to see a test like that
=> Define a Validation Between two fields required for the Jedi
=> Get the dynamic_form_class for a padawan
=> Fill the form with empty value
=> validate the form (it has to be okay).
There was a problem hiding this comment.
I added some assertions in this test and a new test that matches your description
mgu
force-pushed
the
skip-presets-on-empty-fields
branch
from
ad3988e to
82080b1
Compare
3 participants
As a field is not mandatory
If empty, it should be accepted