Fix error on presets_lists endpoint #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to return a serialized Presets list, we tried to instantiate presets with `arguments=[]`. But checks are done in `Presets.__init__` on the arguments provided. This resulted in an `ImproperlyConfigured` Exception. The Serializer now takes the class as `instance` parameter instead of an object.
wo0dyn
approved these changes
Mar 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to return a serialized Presets list, we tried to instantiate
presets with
arguments=[]. But checks are done inPresets.__init__on the arguments provided. This resulted in an
ImproperlyConfiguredException.
The Serializer now takes the class as
instanceparameter instead of anobject.