Skip to content

Conversation

mgu
Copy link
Contributor

@mgu mgu commented Mar 24, 2017

Fix unhandled exception in some cases and allows for better error reporting.

Copy link
Contributor

@brunobord brunobord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine. maybe you could add en entry on the changelog

@brunobord
Copy link
Contributor

also, your branch is out-of-date, it needs a rebase

@mgu mgu force-pushed the fix-unhandled-exceptions branch from ef35ab3 to 1599b2e Compare March 24, 2017 09:59
@mgu mgu requested a review from brunobord March 24, 2017 09:59
Copy link
Contributor

@brunobord brunobord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; after rebase it'll be green to merge

Mickaël Guérin added 3 commits March 27, 2017 11:18
Failing tests to show that we should check unicity in the serializers
(for better error output)
@mgu mgu force-pushed the fix-unhandled-exceptions branch from 1599b2e to 3c65eec Compare March 27, 2017 09:19
@mgu mgu merged commit aa88c2f into master Mar 27, 2017
@mgu mgu deleted the fix-unhandled-exceptions branch March 27, 2017 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants