-
Notifications
You must be signed in to change notification settings - Fork 4
Added Django 1.10 support #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
@mgu you misread. the tox.ini is wrong. |
you are right, I missed your copy/paste error |
dammit, something is wrong here:
|
ok, got it, it was locked in the |
closes #203
7353880
to
05fb8b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
'guillaume.gerard@people-doc.com', | ||
install_requires=[ | ||
'Django<1.10', | ||
'Django', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have set Django<1.11
here instead. Because, it'll install the very latest version of Django here if it's unpinned. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this silly requirement has almost make me lose my mind ; I was working with tox "django110" jobs, and it was still Django 1.9 that was installed. Luckily I did a careful check to the "pip freeze -l" that is executed during the job, or we could have a "fake" Django 1.10 support.
Maybe we could think about having a "latest" job, that installs the latest Django version, run it through a cron job (I don't know if circle-ci is able to do it, but travis does) and periodically check if the latest django release is compatible, in order to anticipate further releases.
Yeah, that would be awesome indeed. |
Review
This PR closes #203
CHANGELOG.rst
Updated