Skip to content

Conversation

brunobord
Copy link
Contributor

@brunobord brunobord commented Feb 12, 2018

Before:

$ cd project/root/directory
$ pytest
[..]
ImportError: No module named demo.settings

pytest-django could not find a Django project (no manage.py file could be found). You must explicitly add your Django project to the Python path to have it picked up.

What we need is to go to the demo directory in order to have the Django Settings Module correctly picked up.

@brunobord brunobord force-pushed the pytest-configuration-fix branch from 0ddbd72 to d859a0e Compare February 12, 2018 13:31
@brunobord brunobord requested a review from wo0dyn February 12, 2018 13:32
…ct root.

Unrelated: fixed a isort bug due to a recent fix.
@brunobord brunobord force-pushed the pytest-configuration-fix branch from d859a0e to 90a5840 Compare February 12, 2018 13:40
Copy link
Contributor

@wo0dyn wo0dyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brunobord brunobord merged commit 459ef6e into master Feb 13, 2018
@brunobord brunobord deleted the pytest-configuration-fix branch February 13, 2018 10:15
brunobord added a commit that referenced this pull request Feb 14, 2018
**Deprecation Warning**: The validation endpoint (using the URL
``forms/(?P<pk>\d+)/validate/``) was only accessible via the ``GET``
verb. It may have caused issues if we tried to validate very long forms,
or forms with very large values, by hitting the querystring size limit.
As a consequence, as of 1.3.0, the ``GET`` method is deprecated in favor
of the ``POST`` method.

- Allow POST method for form validation endpoint.
- [Documentation] Fixed a missing ``cd`` in docs. You can't run pytest
  from project root (#293).
- includes 7 more languages (not translated yet): Czech, Danish,
  Finnish, Canadian French, Hungarian, Japanese, Swedish.
brunobord added a commit that referenced this pull request Feb 14, 2018
**Deprecation Warning**: The validation endpoint (using the URL
``forms/(?P<pk>\d+)/validate/``) was only accessible via the ``GET``
verb. It may have caused issues if we tried to validate very long forms,
or forms with very large values, by hitting the querystring size limit.
As a consequence, as of 1.3.0, the ``GET`` method is deprecated in favor
of the ``POST`` method.

- Allow POST method for form validation endpoint.
- [Documentation] Fixed a missing ``cd`` in docs. You can't run pytest
  from project root (#293).
- includes 7 more languages (not translated yet): Czech, Danish,
  Finnish, Canadian French, Hungarian, Japanese, Swedish.
brunobord added a commit that referenced this pull request Feb 14, 2018
**Deprecation Warning**: The validation endpoint (using the URL
``forms/(?P<pk>\d+)/validate/``) was only accessible via the ``GET``
verb. It may have caused issues if we tried to validate very long forms,
or forms with very large values, by hitting the querystring size limit.
As a consequence, as of 1.3.0, the ``GET`` method is deprecated in favor
of the ``POST`` method.

- Allow POST method for form validation endpoint.
- [Documentation] Fixed a missing ``cd`` in docs. You can't run pytest
  from project root (#293).
- includes 7 more languages (not translated yet): Czech, Danish,
  Finnish, Canadian French, Hungarian, Japanese, Swedish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants