Drop django1.11 support #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syldb
approved these changes
Jun 18, 2020
syldb
left a comment
syldb
left a comment
There was a problem hiding this comment.
Just a comment, thank you for the cleanup!
demo/tests/test_app.py
Outdated
| else: | ||
| # No warning beyond Django 2. | ||
| assert len(w) == 0, w | ||
| # Verify some things there's no warning. |
There was a problem hiding this comment.
Suggested change
| # Verify some things there's no warning. | |
| # Verify there's no warning. |
brunobord
force-pushed
the
drop-django1.11-support
branch
from
00ebfcc to
6c48b8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review
This PR closes #398
CHANGELOG.rstUpdated