Skip to content

Conversation

@syldb
Copy link

@syldb syldb commented Jun 28, 2021

Review

This PR closes #421

  • Tests
  • Docs/comments
    • IN CASE YOU'VE CHANGED THE formidable.yml file: run tox -e swagger-statics to rebuild the swagger static files and commit the diff.
  • Migration(s)
  • CHANGELOG.rst Updated
  • Delete your branch

@syldb syldb requested review from espern and ewjoachim June 28, 2021 12:59
@syldb syldb changed the title Date futur accept bool Future data validation accept bool values Jun 28, 2021
serializer = FutureDateSerializer(data=data)
self.assertTrue(serializer.is_valid())

def test_valid_string_future_data_value(self):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is non-regression, already green before the code logic update

@syldb syldb changed the title Future data validation accept bool values Future date validation accept bool values Jun 28, 2021
@syldb syldb force-pushed the date-futur-accept-bool branch from f0a02c1 to a296d4e Compare June 28, 2021 14:07
@syldb syldb merged commit 25efe5e into master Jun 28, 2021
@syldb syldb deleted the date-futur-accept-bool branch June 28, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"IS_DATE_IN_THE_FUTURE" should also accept boolean values

3 participants