Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This contribution adds implied columns, sub annotation tables, vignettes #6

Merged
merged 28 commits into from
Sep 11, 2018
Merged

Conversation

stolarczyk
Copy link
Member

No description provided.

…st is added as a data.frame column so it can hold multiple elements. Need to work on derived columns to support that
…ample subannotation funcitionality + further changes in loadSampleSubannotation
… in strformat - now it handles multiple elements in the input list
@stolarczyk stolarczyk merged commit 02c9bdc into pepkit:master Sep 11, 2018
@stolarczyk stolarczyk mentioned this pull request Sep 12, 2018
@nsheff
Copy link
Contributor

nsheff commented Sep 12, 2018

Thanks @MichalStolarczyk -- can you also draft a release? Whenever you make a merge into master we need to increment version (which you did) and make a github release.

for future merges, it will be better to open the PR and give a few days for a code review before merging it in, that way others can test and make sure it works before making the official release on master.

@nsheff
Copy link
Contributor

nsheff commented Sep 12, 2018

by the way, I was just looking at the rendered vignettes -- they look fantastic! the html display of the annotation sheets are great, and the prettyPrint on the yaml metadata turned out really well. nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants