K8SPG-260: Fix restart after upgrade #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inelpandzic
previously approved these changes
Oct 1, 2024
nmarukovich
previously approved these changes
Oct 1, 2024
eleo007
requested review from
eleo007,
jvpasinatto,
ptankov and
tplavcic
as code owners
inelpandzic
previously approved these changes
Oct 2, 2024
inelpandzic
reviewed
Oct 2, 2024
Contributor
inelpandzic
left a comment
inelpandzic
left a comment
There was a problem hiding this comment.
@egegunes pls check these failing tests.
hors
previously approved these changes
Oct 3, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| for pod in $(kubectl get pods -l postgres-operator.crunchydata.com/data=postgres --no-headers | awk '{print $1}'); do | ||
| local phase=$(kubectl -n ${NAMESPACE} get ${pod} -o jsonpath={".status.phase"}) | ||
| if [[ "${phase}" != "Running" ]]; then |
Contributor
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| if [[ "${phase}" != "Running" ]]; then | |
| if [[ ${phase} != "Running" ]]; then |
inelpandzic
approved these changes
Oct 3, 2024
| return cluster | ||
| } | ||
|
|
||
| const LabelVersion = "pgv2.percona.com/version" |
Contributor
There was a problem hiding this comment.
Can you reuse this:
Contributor
Author
There was a problem hiding this comment.
unfortunately, no. it causes cyclical import
Collaborator
commit: 522c655 |
pooknull
approved these changes
Oct 3, 2024
jvpasinatto
pushed a commit
that referenced
this pull request
Oct 3, 2024
* K8SPG-260: Fix restart after upgrade * fix envtest * Add cluster restart check to upgrade-minor tests * K8SPG-643: Always try stanza-upgrade after a failed stanza-create * fix upgrade-minor test * improve major-upgrade --------- Co-authored-by: Eleonora Zinchenko <eleonora.zinchenko@percona.com> Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Pods get restarted after deploying 2.5.0 operator without changing
crVersion.Cause:
No version check in crunchy controllers.
Solution:
Add version checks.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability