Fix null pointer dereference in pmproxy #2375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I did quite extensive testing of this patch and so far, no crashes (core dumps) were observed with this patch applied. Unfortunately there is no direct way how to reliably reproduce this null pointer dereference, so it is not possible to test it with 100% certainty. |
natoscott
reviewed
Oct 20, 2025
A null pointer dereference in libpcp_web when handling battons causing pmproxy to crash (core dump). The crash happens from time to time when pmproxy is under load and serving data in paralel to more pmproxy clients. This patch fixes the null pointer dereference. Resolves: RHEL-70195
Resolves: bz2404769
Resolves: bz2404770
* No need to check for NULL before calling free() * Improved diagnostic messages
natoscott
reviewed
Oct 23, 2025
Member
natoscott
left a comment
natoscott
left a comment
There was a problem hiding this comment.
@kurik I was reflecting further on this and I think we should not hide these conditions behind debug statements. Its OK to improve the resilience here but there are still bugs that need fixing. Could you drop the pmDebugOptions.series use, and change the fprintf statements to __pmNotify(LOG_ERR, ...) so that we get logs+timestamps when these things happen?
Contributor
Author
|
@natoscott Makes sense to me - reworked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A null pointer dereference in libpcp_web when handling battons causing pmproxy to crash (core dump). The crash happens from time to time when pmproxy is under load and serving data in paralel to more pmproxy clients. This patch fixes the null pointer dereference.
Resolves: RHEL-70195
Resolves: bz2401579