Skip to content

More math helpers #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2024
Merged

More math helpers #12

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f74a79
Formatting
rappie Mar 11, 2024
71103cc
Signed to unsigned `abs` and `diff`
rappie Mar 11, 2024
74b4891
Add `diff` for uint to uint
rappie Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/MathHelper.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ abstract contract MathHelper {
function min(uint256 a, uint256 b) internal pure returns (uint256) {
return a < b ? a : b;
}
// Forked from https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v5.0.0/contracts/utils/math/SignedMath.sol

// Forked from https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v5.0.0/contracts/utils/math/SignedMath.sol
function max(int256 a, int256 b) internal pure returns (int256) {
return a > b ? a : b;
}
Expand All @@ -15,4 +15,16 @@ abstract contract MathHelper {
function abs(int128 n) internal pure returns (int128) {
return n >= 0 ? n : -n;
}

function abs(int256 n) internal pure returns (uint256) {
return n >= 0 ? uint256(n) : uint256(-n);
}

function diff(int256 a, int256 b) internal pure returns (uint256) {
return a >= b ? uint256(a - b) : uint256(b - a);
}

function diff(uint256 a, uint256 b) internal pure returns (uint256) {
return a >= b ? a - b : b - a;
}
}