Skip to content

Fix compiler warnings #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Fix compiler warnings #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/AssertHelper.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ abstract contract AssertHelper {
reason4
)
);
assertWithMsg(isEqual, assertMsg);
Copy link
Member

@rappie rappie Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find 🙂

}

function assertErrorsAllowed(
Expand Down
2 changes: 1 addition & 1 deletion src/RandomHelper.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pragma solidity ^0.8.0;
abstract contract RandomHelper {
/// @notice Shuffle an array using Fisher-Yates algorithm
/// @dev Based on https://gist.github.com/scammi/602387a22e04c77beb73c0ebc0f0bc18
function shuffleArray(uint256[] memory shuffle, uint256 entropy) internal {
function shuffleArray(uint256[] memory shuffle, uint256 entropy) internal pure {
for (uint256 i = shuffle.length - 1; i > 0; i--) {
uint256 swapIndex = entropy % (shuffle.length - i);

Expand Down