add support for Module::Build #6 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarg
reviewed
Oct 4, 2022
simbabque
force-pushed
the
module-build
branch
from
c3b44a4 to
dbe3ef4
Compare
oalders
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I did the right thing here. I tested it locally with bats. I don't know how well installing deps will work, because it seems Build.PL does not create a cpanfile automatically.
cpanm --installdepscan work with Build.PL, but we don't use it.cpmdoesn't seem to support it installing deps without a cpanfile.It also leaves behind some files in the test build directory that don't get cleaned up with
./Build clean. I added those to gitignore, but I'm not sure if they need to be removed in any other way.Closes #6