Get the substatus of a failed assertion #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterkip
force-pushed
the
GL-sub-status_for_consumers_in_assertion
branch
2 times, most recently
from
459602c to
cf53537
Compare
timlegge
requested changes
Feb 1, 2023
Contributor
timlegge
left a comment
timlegge
left a comment
There was a problem hiding this comment.
Looks fine but needs some pod for the success and see other comment
This allows consumers to expose the reason of the failure. Signed-off-by: Wesley Schwengle <waterkip@cpan.org>
waterkip
force-pushed
the
GL-sub-status_for_consumers_in_assertion
branch
from
cf53537 to
fc6a199
Compare
timlegge
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows consumers to expose the reason of the failure.
Signed-off-by: Wesley Schwengle waterkip@cpan.org