testapp config tests and automated selenium testing #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterkip
reviewed
Feb 24, 2023
timlegge
force-pushed
the
selenium-tests-2023-02-23
branch
4 times, most recently
from
faef746 to
d557036
Compare
waterkip
reviewed
Feb 26, 2023
xt/testapp/t/004_selenium.t
Outdated
|
|
||
| my $ret = $driver->get('https://netsaml2-testapp.local'); | ||
| if ( ! $ret ) { | ||
| die "Unable to access https://netsaml2-testapp.local"; |
Collaborator
There was a problem hiding this comment.
I would perhaps use BAILOUT from Test::More here.
xt/testapp/t/004_selenium.t
Outdated
|
|
||
| =cut | ||
| if (! -d "$RealBin/selenium" ) { | ||
| warn "Created directory $RealBin/selenium\n" if (make_path("$RealBin/selenium")); |
Collaborator
There was a problem hiding this comment.
Is this a warn or more some kind of informational message?
Contributor
Author
There was a problem hiding this comment.
informational - could the print
testapp: Add automated selenium testing using the testapp
timlegge
force-pushed
the
selenium-tests-2023-02-23
branch
from
d557036 to
5fb1f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.