Skip to content

[Snyk] Security upgrade eslint from 8.6.0 to 9.0.0 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade eslint from 8.6.0 to 9.0.0 #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"dependencies": {
"@typescript-eslint/eslint-plugin": "^5.9.0",
"@typescript-eslint/parser": "^5.9.0",
"eslint": "^8.6.0",
"eslint": "^9.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Breaking Change Risk: This ESLint upgrade from v8.6.0 to v9.0.0 is a major version jump that introduces significant breaking changes. ESLint v9 includes new configuration format requirements (flat config), rule changes, and Node.js version requirements that may cause compatibility issues with the current TypeScript ESLint plugins and existing configurations.

"typescript": "^4.5.4"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TypeScript version (^4.5.4) is also quite outdated and may have compatibility issues with the newer ESLint and TypeScript ESLint packages. Consider upgrading to TypeScript ^5.0.0 or later for better compatibility and access to newer language features.

},
Comment on lines 6 to 11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Dependency Compatibility Issue: The TypeScript ESLint packages (@typescript-eslint/eslint-plugin@^5.9.0 and @typescript-eslint/parser@^5.9.0) are severely outdated and incompatible with ESLint v9. These v5 packages only support ESLint v6-8, which will cause runtime errors and prevent the linting functionality from working.

Suggested change
"dependencies": {
"@typescript-eslint/eslint-plugin": "^5.9.0",
"@typescript-eslint/parser": "^5.9.0",
"eslint": "^8.6.0",
"eslint": "^9.0.0",
"typescript": "^4.5.4"
},
"dependencies": {
"@typescript-eslint/eslint-plugin": "^8.0.0",
"@typescript-eslint/parser": "^8.0.0",
"eslint": "^9.0.0",
"typescript": "^4.5.4"
},

"scripts": {
Expand Down