Skip to content

[Snyk] Upgrade @typescript-eslint/eslint-plugin from 5.9.0 to 5.62.0 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Upgrade @typescript-eslint/eslint-plugin from 5.9.0 to 5.62.0 #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Runs ESLint on code",
"main": "action.js",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing package-lock.json file creates reproducibility and security issues. Without a lock file, different installations may resolve to different dependency versions, potentially introducing vulnerabilities or breaking changes. Consider adding a package-lock.json file to ensure consistent dependency resolution across environments.

"dependencies": {
"@typescript-eslint/eslint-plugin": "^5.9.0",
"@typescript-eslint/eslint-plugin": "^5.62.0",
Comment on lines 6 to +7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛑 Version Inconsistency: The @typescript-eslint/eslint-plugin is being upgraded to 5.62.0, but @typescript-eslint/parser remains at 5.9.0. These packages should be kept in sync as they work together and version mismatches can cause compatibility issues, unexpected behavior, or ESLint rule failures.

Suggested change
"dependencies": {
"@typescript-eslint/eslint-plugin": "^5.9.0",
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/eslint-plugin": "^5.62.0",
"@typescript-eslint/parser": "^5.62.0",

"@typescript-eslint/parser": "^5.9.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESLint version (8.6.0) is significantly outdated. ESLint 8.6.0 was released in January 2022 and has known security vulnerabilities. Consider upgrading to the latest ESLint 8.x version to ensure compatibility with the upgraded TypeScript ESLint packages and address security issues.

"eslint": "^8.6.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TypeScript version (4.5.4) is outdated and may not be compatible with the newer TypeScript ESLint packages. TypeScript 4.5.4 was released in December 2021. Consider upgrading to a more recent version to ensure compatibility and access to newer language features.

"typescript": "^4.5.4"
Expand Down