Skip to content

[Snyk] Upgrade typescript from 4.5.4 to 4.9.5 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

[Snyk] Upgrade typescript from 4.5.4 to 4.9.5 #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"@typescript-eslint/eslint-plugin": "^5.9.0",
"@typescript-eslint/parser": "^5.9.0",
"eslint": "^8.6.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESLint version (^8.6.0) is also quite outdated. Since this is a major TypeScript upgrade, consider updating ESLint to a more recent version to ensure compatibility and access to the latest linting rules and bug fixes. ESLint 8.6.0 was released in early 2022, and there have been many improvements since then.

"typescript": "^4.5.4"
"typescript": "^4.9.5"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TypeScript upgrade looks good and is necessary for security and compatibility. However, the lock file (pnpm-lock.yaml) will need to be updated to reflect this change. The current lock file still references TypeScript 4.5.4 in multiple places, which could lead to inconsistencies between the package.json specification and the actual installed version.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider updating the TypeScript ESLint packages as well. The current versions (@typescript-eslint/eslint-plugin@^5.9.0 and @typescript-eslint/parser@^5.9.0) are quite old and may not fully support TypeScript 4.9.5 features. This could lead to compatibility issues or missed linting opportunities for newer TypeScript syntax.

},
"scripts": {
"test": "exit 0"
Expand Down