Skip to content

Fix 157 inconsistent data handling with embedded entities #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2024
Merged

Fix 157 inconsistent data handling with embedded entities #159

merged 4 commits into from
Jul 30, 2024

Conversation

@ng-galien
Copy link
Collaborator

Fix #157

Description:

There appears to be an issue with handling embedded entities using RSQL. When querying for embedded entities, the behavior differs depending on whether or not a mapping for an embedded entity is set.

Steps to Reproduce:

  • Clone the repository rsql-embedded-bug-repository.
  • Follow the README instructions to set up and run the project.
  • Execute the provided test cases or run the application to reproduce the issue.

Expected Behavior:

Querying with or without remapping should be possible on embedded entities.

Actual Behavior:

Querying with mappings on embedded entities leads to an UnknownPropertyException. Without remapping the correct data is returned.

Additional Information:

Potential Impact:

This bug impacts any application relying on RSQL queries for embedded entities, particularly when using property mapping functionality, potentially causing data consistency issues and incorrect data retrieval.

ng-galien added 4 commits July 19, 2024 00:32
@ng-galien
Update RSQLJPAContext and RSQLJPAPredicateConverter classes
f7a39c3 
The RSQLJPAContext class has been updated to include a new field 'managedType', while RSQLJPAPredicateConverter class now also returns 'managedType'. The returned context from 'findPropertyPathInternal' method in RSQLJPAPredicateConverter is now being utilized to get the 'managedType'.
@ng-galien
Add account-related entities and related tests
ecda6c6 
New model classes for `AccountEntity`, `AddressEntity`, and `AddressHistoryEntity` have been created. The `AccountRepository` interface has also been added. Accompanying these, several tests were introduced into `RSQLJPASupportTest` to ensure correct functionality.
@ng-galien
Change access modifiers in RSQLJPAContext
edd9084 
The access modifiers for the path, attribute, and managedType variables in the RSQLJPAContext class have been updated. These were previously set as private, but have now been made package-private.
@ng-galien
Add Lombok annotations to account entities
34c036c 
Replaced manual getters and setters in the account, address, and address history entities with Lombok annotations. This simplifies the code by using the @Getter and @Setter annotations to generate these methods automatically, making the entities more readable and maintainable.
tobjohnbx
tobjohnbx approved these changes Jul 25, 2024
View reviewed changes
Copy link

@tobjohnbx tobjohnbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine <3

@perplexhub perplexhub merged commit 6da2242 into perplexhub:master Jul 30, 2024
@tobjohnbx tobjohnbx mentioned this pull request Jul 31, 2024
Closed
@perplexhub perplexhub mentioned this pull request Sep 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tobjohnbx tobjohnbx tobjohnbx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug Report: Inconsistent Data Handling with Embedded Entities

3 participants

@ng-galien @tobjohnbx @perplexhub