[BREAKINGCHANGE] TraceTable: configure link in panel spec#211
Merged
andreasgerstmayr merged 9 commits intoperses:mainfrom Aug 25, 2025
Merged
[BREAKINGCHANGE] TraceTable: configure link in panel spec#211andreasgerstmayr merged 9 commits intoperses:mainfrom
andreasgerstmayr merged 9 commits intoperses:mainfrom
Conversation
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr
changed the title
tracetable/src/TraceTablePanel.tsx
Outdated
| }); | ||
|
|
||
| return `/explore?${traceLinkParams}`; | ||
| RouterComponent?: DataTableProps['RouterComponent']; |
Contributor
Author
There was a problem hiding this comment.
Should I create a new context for this one?
RouterContext or PluginContext or sth, with two props: RouterComponent (by default, <Link> from react-router-dom) and navigate (by default, the function returned by useNavigate()).
This allows host applications to use different routing libraries (or different versions of react-router).
Contributor
There was a problem hiding this comment.
I think it makes sense to create a provider or reuse one existing to allow custom redirection routes from plugins panels. It makes more sense to me that is a RouterContext
Member
There was a problem hiding this comment.
To me it fine to have a new provider RouterProvider, its scope is clear.
Contributor
Author
There was a problem hiding this comment.
Thank you both for your input! I created perses/perses#3140 to implement RouterProvider with RouterContext.
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
6 tasks
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
jgbernalp
approved these changes
Aug 25, 2025
rafi-ruetcse17
pushed a commit
to opnpulse/perses_plugins
that referenced
this pull request
Sep 1, 2025
* [BREAKINGCHANGE] TraceTable: configure attribute links in panel spec Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * use RouterContext Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * update test Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * move react-router-dom to dev dependencies (only required for tests) Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * make RouterComponent optional Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * use replaceVariablesInString utility Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> --------- Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
abelyakin
pushed a commit
to abelyakin/plugins
that referenced
this pull request
Jan 14, 2026
* [BREAKINGCHANGE] TraceTable: configure attribute links in panel spec Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * use RouterContext Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * update test Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * move react-router-dom to dev dependencies (only required for tests) Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * make RouterComponent optional Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * use replaceVariablesInString utility Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> --------- Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same as #210, but for
TraceTable.Screenshots
no UI changes
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes