Skip to content

[BUGFIX]: Add plugins filter to query editor from prometheus explorer#428

Merged
shahrokni merged 1 commit intoperses:mainfrom
shahrokni:fix/prometheus-queryeditor-explorer-behavior
Nov 5, 2025
Merged

[BUGFIX]: Add plugins filter to query editor from prometheus explorer#428
shahrokni merged 1 commit intoperses:mainfrom
shahrokni:fix/prometheus-queryeditor-explorer-behavior

Conversation

@shahrokni
Copy link
Copy Markdown
Contributor

@shahrokni shahrokni commented Oct 29, 2025

⚠️ WAITING FOR THE DEPENDENCIES

Please Check perses/perses#3514

Closes perses/perses#3459

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

@shahrokni shahrokni marked this pull request as ready for review October 29, 2025 15:05
@shahrokni shahrokni force-pushed the fix/prometheus-queryeditor-explorer-behavior branch from 1e0e3d7 to 916faf0 Compare October 30, 2025 09:30
explorer,
} = useExplorerManagerContext<MetricsExplorerQueryParams>();

const filteredQueryPlugins = explorer ? ['PrometheusTimeSeriesQuery'] : [];
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand the check with explorer. Let's always use PrometheusTimeSeriesQuery, no?

@shahrokni shahrokni force-pushed the fix/prometheus-queryeditor-explorer-behavior branch from 916faf0 to bbf36ec Compare October 31, 2025 11:34
Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
@shahrokni shahrokni force-pushed the fix/prometheus-queryeditor-explorer-behavior branch from bbf36ec to 37e2aab Compare November 5, 2025 14:49
@shahrokni shahrokni added this pull request to the merge queue Nov 5, 2025
Merged via the queue into perses:main with commit b7161c9 Nov 5, 2025
21 of 22 checks passed
@shahrokni shahrokni deleted the fix/prometheus-queryeditor-explorer-behavior branch November 5, 2025 15:05
abelyakin pushed a commit to abelyakin/plugins that referenced this pull request Jan 14, 2026
…perses#428)

Signed-off-by: Seyed Mahmoud SHAHROKNI <seyedmahmoud.shahrokni@amadeus.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loki shows up in Prometheus Explorer

3 participants