Make an attempt to get environment information for non-Windows platforms#1105
Merged
nohwnd merged 2 commits intopester:masterfrom Sep 30, 2018
Merged
Make an attempt to get environment information for non-Windows platforms#1105nohwnd merged 2 commits intopester:masterfrom
nohwnd merged 2 commits intopester:masterfrom
Conversation
414a2b2 to
efe3a8d
Compare
Contributor
Author
|
@dlwyatt @it-praktyk @nohwnd - Could you take a look to see if I've taken an appropriate approach? Thanks! |
Member
|
@JamesWTruher tested it on macOS and the only thing I found that the username is not just username but a whole user info. To print just username it should be |
Contributor
|
Tested on Linux.
|
nohwnd
reviewed
Sep 30, 2018
Contributor
|
Member
|
@it-praktyk what does that mean? That it works? Or that it does not work? More context please. (btw I added the |
Contributor
|
It works like expected now. Means returns only the username, the single word.
|
Contributor
Author
|
I was wondering about |
Member
|
It’s out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm definitely missing environment information when running Pester in our CI on Non-Windows platforms. I would love if the logs had that information. This is an attempt at providing that information with tools that will probably be there. I'm using
unameandidto provide that info. If those tools aren't there, we won't be any worse off, but if they are there, then we can provide the test environment pretty well.