Skip to content

Improve NUnit xml report#1180

Merged
nohwnd merged 5 commits intopester:masterfrom
gnuechtel:ImproveNUnitXmlReport
Jan 3, 2019
Merged

Improve NUnit xml report#1180
nohwnd merged 5 commits intopester:masterfrom
gnuechtel:ImproveNUnitXmlReport

Conversation

@gnuechtel
Copy link
Copy Markdown
Contributor

Fix for #1179

* remove unnecessary grouping by step implementation source
  - repeated steps will be reported in correct order
  - NUnit report XML file is leaner
* verify new behavior in Gherkin.Tests.ps1
@nohwnd
Copy link
Copy Markdown
Member

nohwnd commented Dec 21, 2018

@cgnuechtel fails this in 9 places (you should be able to see that in the details as well I hope). I guess you are using . navigation from array to child item property which does not work in PowerShell 2. You need Select-Object -ExpandProperty Node most likely, but I haven't looked at the code.

 [-] should contain all scenarios of feature 1 with correct names and test results 13ms
2018-12-20T19:43:23.4716250Z       RuntimeException: Property 'Node' cannot be found on this object. Make sure that it exists.
2018-12-20T19:43:23.4716250Z       at line: 299 in C:\agent\_work\3\s\Functions\Gherkin.Tests.ps1

@nohwnd
Copy link
Copy Markdown
Member

nohwnd commented Dec 22, 2018

@cgnuechtel LGTM. @fourpastmidnight any objections to merging this?

@gnuechtel
Copy link
Copy Markdown
Contributor Author

I would like to suggest more small but important improvements with the last two commits.

  1. I think the position of the invocation of $Pester.EnterTestGroup was not correct, since it produced nested elements in case of error
  2. I also think, that the file name should be replaced by the feature name in the test report (in any case of error the file name would occur in the stack trace)

@nohwnd
Copy link
Copy Markdown
Member

nohwnd commented Jan 3, 2019

@cgnuechtel nobody objects, so merging.

@nohwnd nohwnd merged commit 453df17 into pester:master Jan 3, 2019
@gnuechtel gnuechtel deleted the ImproveNUnitXmlReport branch January 4, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants