Add more information on the passthru code coverage property#1190
Merged
nohwnd merged 1 commit intopester:masterfrom Jan 3, 2019
Merged
Add more information on the passthru code coverage property#1190nohwnd merged 1 commit intopester:masterfrom
nohwnd merged 1 commit intopester:masterfrom
Conversation
Member
|
@Thilas Not sure if the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #727, I'm adding a few informations on the code coverage property returned by
Invoke-Pesterwhen using-PassThruparameter:StartLine&EndLineStartColumn&EndColumnHitCountI kept though existing
Linebut it's just returning the same value asStartLine. This is only for compatibility purpose and I was wondering if this is necessary here?I also removed
AllCommandsthat was introduced by #920 but to me it's redundant with what is already provided (i.e.HitCommandsandMissedCommands).@nohwnd, any thoughts? Could you review? Thanks.