Fixing a mocking parameter bug#187
Merged
dlwyatt merged 1 commit intopester:Betafrom Aug 13, 2014
Merged
Conversation
@Jaykul pointed out a problem where the $args variable in a mock's stub function can resolve to the value of $args in a parent scope; the automatic version of $args only exists for non-advanced functions. The prototype function used to generate these stubs now looks specifically for a variable named args in the local scope, not allowing it to fetch the parent scope's values.
dlwyatt
added a commit
that referenced
this pull request
Aug 13, 2014
Fixing a mocking parameter bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Jaykul pointed out a problem where the
$argsvariable in a mock's stub function can resolve to the value of$argsin a parent scope; the automatic version of$argsonly exists for functions without the CmdletBinding attribute. (Mocks of cmdlets and advanced functions can demonstrate the bug, if a variable named$argsis defined in a parent scope of the call to the mocked command.)The prototype function used to generate these stubs now looks specifically for a variable named args in the local scope, not allowing it to fetch the parent scope's values.