Implement ExcludeTags, with tests. Fixes #231#234
Closed
Jaykul wants to merge 3 commits intopester:masterfrom
Closed
Implement ExcludeTags, with tests. Fixes #231#234Jaykul wants to merge 3 commits intopester:masterfrom
Jaykul wants to merge 3 commits intopester:masterfrom
Conversation
These will come back when the LanguageDecoupling branch comes in
Member
|
I had to fixup the commits to one and remove some extra whitespace so it is merged as: 7a08bce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think @fearthecowboy already submitted a fix for #231, but I already did the work anyway, so here's mine. You can compare them for fun. I wrote a few extra tests (pulled from @dlwyatt's LanguageDecoupling branch) and I have the changes for Gherkin and output.ps1 to apply on that branch, on my copy of the LanguageDecoupling branch ;-)
Looks like the main difference between my fix and @fearthecowboy's is that I called the parameter ExcludeTagFilter (and injected it in the parameter list, instead of adding it on the end), and wrote the extra tests in Describe to verify the functionality.