Skip to content

The test Style rules corrected - branch DevelopmentV4#691

Merged
nohwnd merged 2 commits intopester:masterfrom
it-praktyk:DevV4_Style_Rules_corrections
Mar 27, 2017
Merged

The test Style rules corrected - branch DevelopmentV4#691
nohwnd merged 2 commits intopester:masterfrom
it-praktyk:DevV4_Style_Rules_corrections

Conversation

@it-praktyk
Copy link
Copy Markdown
Contributor

@it-praktyk it-praktyk commented Jan 20, 2017

  • after correction ps1, psm1 files in the root Pester directory are checked by 'Style rules' too
  • trailing spaces removed,
  • tabs replace with 4 spaces

The related issue #689

@it-praktyk it-praktyk changed the title The test Style rules corrected The test Style rules corrected - branch DevelopmentV4 Jan 20, 2017
@nohwnd
Copy link
Copy Markdown
Member

nohwnd commented Jan 20, 2017

Thanks. Is there a reason why is this targetting v4 instead of v3?

@it-praktyk
Copy link
Copy Markdown
Contributor Author

The only one reason. My mistake :-)

Can you merge back that pull request to v3 too? If not I can prepare the next pull request.

@nohwnd
Copy link
Copy Markdown
Member

nohwnd commented Jan 20, 2017 via email

@it-praktyk it-praktyk force-pushed the DevV4_Style_Rules_corrections branch 3 times, most recently from 58afc73 to 7a959b3 Compare January 22, 2017 18:34
@dlwyatt dlwyatt changed the base branch from DevelopmentV4 to master March 19, 2017 20:43
@it-praktyk it-praktyk changed the title The test Style rules corrected - branch DevelopmentV4 [Work In Progress] The test Style rules corrected - branch DevelopmentV4 Mar 22, 2017
…e root folder. Trailing spaces removed, tabs replaced with 4 spaces in files - to fulfill 'Style rules'.
@it-praktyk it-praktyk force-pushed the DevV4_Style_Rules_corrections branch from 475fa5a to 2b51d5a Compare March 22, 2017 23:51
@it-praktyk it-praktyk changed the title [Work In Progress] The test Style rules corrected - branch DevelopmentV4 The test Style rules corrected - branch DevelopmentV4 Mar 22, 2017
@it-praktyk
Copy link
Copy Markdown
Contributor Author

@nohwnd , I've resolved conflicts, please consider merge. Thx.

@it-praktyk it-praktyk force-pushed the DevV4_Style_Rules_corrections branch from 805794e to 05a1c0c Compare March 23, 2017 00:34
@nohwnd nohwnd merged commit ceac19e into pester:master Mar 27, 2017
@it-praktyk it-praktyk deleted the DevV4_Style_Rules_corrections branch March 27, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants