Skip to content

Throw on Assert-VerifiableMocks#881

Merged
nohwnd merged 1 commit intopester:masterfrom
nohwnd:throw-on-assert-verifiable-mocks
Sep 15, 2017
Merged

Throw on Assert-VerifiableMocks#881
nohwnd merged 1 commit intopester:masterfrom
nohwnd:throw-on-assert-verifiable-mocks

Conversation

@nohwnd
Copy link
Copy Markdown
Member

@nohwnd nohwnd commented Sep 15, 2017

Fix #880

@it-praktyk it-praktyk self-requested a review September 15, 2017 18:01
Copy link
Copy Markdown
Contributor

@it-praktyk it-praktyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about Get-MockDynamicParameters?

I know that my issue was related to internal tests of Pester and I'm not sure if someone can call Get-MockDynamicParameters too.

@nohwnd
Copy link
Copy Markdown
Member Author

nohwnd commented Sep 15, 2017

@it-praktyk They can, but I don't see any reason why they should. Let's merge as it is?

@nohwnd
Copy link
Copy Markdown
Member Author

nohwnd commented Sep 15, 2017

Well, once I add CmdletBinding of course 👍

@it-praktyk
Copy link
Copy Markdown
Contributor

OK, for me.

@nohwnd nohwnd merged commit fd351de into pester:master Sep 15, 2017
it-praktyk pushed a commit to it-praktyk/Pester that referenced this pull request Sep 17, 2017
@nohwnd nohwnd deleted the throw-on-assert-verifiable-mocks branch January 11, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants