Remove unjustified uses of bare 'except' clause#148
Merged
methane merged 1 commit intoPyMySQL:masterfrom Sep 23, 2013
rfk:no-bare-except
Merged
Remove unjustified uses of bare 'except' clause#148methane merged 1 commit intoPyMySQL:masterfrom rfk:no-bare-except
methane merged 1 commit intoPyMySQL:masterfrom
rfk:no-bare-except
Conversation
Member
|
Merged. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyMySQL contains several uses of a bare 'except' clause, like this::
Using bare except is almost always a bad idea, as it captures whole-program control flow exceptions like SystemExit, KeyboardInterrupt and gevent.Timeout. This PR changes it to use the "except Exception" form, which should capture anything of interest while leaving control flow exceptions untouched.
As concrete motivation, I found this because the existing code doesn't cooperate with gevent timeouts. Code like this::
Doesn't time out correctly, because PyMySQL swallows the gevent.Timeout exception and converts it into a DBAPI error. Ideally it would pass through the gevent.Timeout exception unchanged.