Rename Geometry Constructor Methods For Consistency #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vast majority of constructors are now in the form `NewFoo`, where `Foo` is the name of the thing being constructed (e.g. a geometry type such as `MultiPolygon`). Previously, the constructors were named so that the type that was being constructed _from_ was also mentioned. E.g. `NewPolygonFromRings` was renamed to `NewPolygon`. The `FromRings` part really was redundent, since polygons are always constructed from their constituent rings (there really is no other practical way to construct them).
Owner
Author
|
The build is failing due to a 504 from coveralls... The actual main CI part is working though. I'm going to ignore it for now, and investigate what's going wrong there if it keeps happening (I'm guessing it's probably a transient problem). |
Owner
Author
|
Thanks for the speedy review @albertteoh 🥳 |
peterstace
deleted the
rename_geometry_constructor_methods_for_consistency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The vast majority of constructors are now in the form
NewFoo, whereFoois the name of the thing being constructed (e.g. a geometry type such asMultiPolygon).Previously, the constructors were named so that the type that was being constructed from was also mentioned.
E.g.
NewPolygonFromRingswas renamed toNewPolygon. TheFromRingspart really was redundant, since polygons are always constructed from their constituent rings (there really is no other practical way to construct them).Check List
Have you:
Added unit tests? N/A, just a rename.
Add cmprefimpl tests? (if appropriate?) N/A.
Related Issue
N/A
Benchmark Results
N/A