Added walet unlocking function #121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertodd
reviewed
Oct 6, 2016
bitcoin/rpc.py
Outdated
|
|
||
| def unlockwallet(self, password, timeout=60): | ||
| """Stores the wallet decryption key in memory for 'timeout' seconds. | ||
| Should be used with `getpass` library |
Owner
There was a problem hiding this comment.
Why should this be used with getpass specifically?
Contributor
Author
There was a problem hiding this comment.
So it won't echo the password into the terminal.
Owner
There was a problem hiding this comment.
Eh, I don't think we should put that in the comment - people can use all kinds of things to get the password from the user.
Otherwise the patch looks good; just remove that bit.
Contributor
Author
There was a problem hiding this comment.
I'll reopen a new pull request
Contributor
Author
|
Opened new pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New function to unlock the wallet from the code.
Should be used with
getpasslibrary