Simplify JIT configuration #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead of adding custom targets source file can be indicator to run the custom command. - Some redundant compile properties removed, and some adjusted. - CMakeFiles can also serve to store temporary minilua generator to not pollute the binary directory and using Gitignore for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIT directory can be nicely wrapped as a simple OBJECT library. In this case everything seems to propagate properly forward.Edit: This didn't work as it complicates propagating compile options. Bottom rule of a thumb: adding separate libraries inside a mono-repo needs a subdirectory to be as much self-contained as possible. Subdirectories like this are very tied to the global PHP and Zend headers and even compile properties of the extension itself.