Sync booleans #19
Merged
Sync booleans #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
petk
commented
Nov 24, 2024
petk
commented
- CMake variables (TRUE/FALSE/ON/OFF)
- Preprocessor macros simplified where possible
- option() default value is OFF
- Missing ZEND_ENABLE_STATIC_TSRMLS_CACHE added to phpdbg shared module
- FindSendmail refactored also for Windows usage
- Some cache variables converted to regular/local/directory variables
- CMake variables (TRUE/FALSE/ON/OFF) - Preprocessor macros simplified where possible - option() default value is OFF - Missing ZEND_ENABLE_STATIC_TSRMLS_CACHE added to phpdbg shared module - FindSendmail refactored also for Windows usage - Some cache variables converted to regular/local/directory variables
- Updated module docs - get_cmake_property usages replaced with more common get_property() as the former is more for CMake core properties than custom global ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.