💡 Cross-Repo Impact-Aware Review Annotations for Downstream Breakage Detection #653
Replies: 4 comments 1 reply
-
|
Specifically, this would be implemented in our pr-review workflow. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
📋 Initiative planned by the BMAD Scrum Master (Bob). Epic #748 — Cross-repo impact-aware review annotations: proactive downstream-breakage detection in the pr-review pipeline 5 stories created (inert — labelled
Open questions for review:
Review the epic and its sub-issue DAG, adjust as needed, then add |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
Extend the pr-review pipeline to detect and annotate when changes to shared reusable workflows, shell libraries, or prompt files in
.github-privatecould break consumer repos (Broodly, TalkTerm, markets, google-app-scripts). CodeRabbit shipped multi-repo analysis in March 2026, validating this as an emerging market expectation. The project's ring-staged release strategy mitigates blast radius after deployment, but does not provide proactive visibility during review — a reviewer currently has no signal about downstream impact until the change hits a consumer ring.Market Signal
CodeRabbit launched multi-repo analysis (March 2026): when a PR changes a shared API, type definition, or database schema, CodeRabbit checks linked repositories for downstream breakage. GitHub Copilot's agentic code review (March 2026) gathers full project context before analyzing PRs. The trend toward context-rich, ecosystem-aware review is accelerating — isolated single-repo review is becoming insufficient for platform/infrastructure repos that serve multiple consumers.
User Signal
The project deploys reusable workflows to 4+ consumer repos via ring-staged promotion. Issue #463 (PR review never reviews at green CI) and the self-host deadlock pattern (#619) demonstrate that cross-repo breakage is a real operational risk. The deploy mechanism (ring-staged via channel tags) mitigates blast radius AFTER a change lands, but provides no PROACTIVE signal during review. Merged PR #606 (oversized PR handling) shows the review pipeline already handles complex cross-cutting concerns — downstream impact is a natural extension.
Technical Opportunity
The project's architecture enables this: consumer repos are known and enumerable (documented in the ring-staged release strategy). The pr-review pipeline's
review-cycle.shalready assembles context from multiple sources. A downstream-impact check would:scripts/lib/, prompts/)engine.sh's triage tier (haiku 4.5) can handle the lightweight compatibility-check pass at minimal cost.Assessment
Adversarial Review
Strongest objection: The ring-staged release strategy already mitigates downstream breakage by validating changes in ring-0 (self-host) before promoting to consumers. Cross-repo impact checking during review is redundant with the ring gates.
Rebuttal: Rings mitigate blast radius AFTER a change lands but do not provide PROACTIVE visibility during review. A reviewer seeing "this change to
ci-status.shis consumed by 4 downstream repos'pr-review.yml" can make better-informed decisions — and catch breaking interface changes before they enter ring-0. The self-host deadlock (#619) proves that even ring-0 validation can fail when the broken agent gates its own fix. Shift-left detection during review is complementary to, not redundant with, the ring model.Suggested Next Step
.github-privateand consumer repos (reusable workflow refs, shell lib imports, prompt file paths).consumer-manifest.jsonlisting each consumer repo and its dependency paths.review-cycle.shthat runs at the triage tier (haiku 4.5) to flag potential breakage.Beta Was this translation helpful? Give feedback.
All reactions