Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Accessibility - can't click on Facepile labels #232

@edent

Description

@edent

I can't click on the text labels next to the Facepile checkboxes:
List of checkboxes

The cause is:
https://github.com/pfefferle/wordpress-semantic-linkbacks/blob/master/semantic-linkbacks.php#L96

printf( '<input name="semantic_linkbacks_facepiles[]" type="checkbox" value="%1$s" %2$s />%3$s<br />', $key, checked( in_array( $key, $facepile, true ), true, false ), $value );

The correct output should be something like:

<input name="semantic_linkbacks_facepiles[]" type="checkbox" value="mention" checked="checked" id="mention">
<label for="mention">Mention</label><br>;

This will require adding an id to each input. Would you like me to create a PR for this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions