Complex Query

[dshanske]

wordpress-webmention/includes/class-webmention-receiver.php

Line 534 in b212cf1

public static function check_dupes( $commentdata ) {

Wondering...the code looks for webmention_source_url, then _crossposting_link. And in the future, we discussed switching to source_url to match activitypub.

Wondering if there is a reason we shouldn't construct a single query with WP_Meta_Query and OR?

Essentially..

                        'meta_query' => array(
                                'relation' => 'OR',
                                // Check for source_url, which is used by Refback, ActivityPub, and will eventually be used by Webmention as well.
                                array(
                                        'key'   => 'source_url',
                                        'value' => $commentdata['comment_author_url'],
                                ),
                                /* check for duplicate webmentions using the old property.
                                 */
                                array(
                                        'key'   => 'webmention_source_url',
                                        'value' => $commentdata['comment_author_url'],
                                ),
                                array(
                                        'key'   => '_crossposting_link',
                                        'value' => $commentdata['comment_author_url'],
                                ),
                        ),

[dshanske]

Addressed via #386