Multiple scoped HRQs with the same name #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utam0k
reviewed
Aug 5, 2025
internal/hrq/utils/scopedhrq.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| maxRQNameLength = 253 |
Member
There was a problem hiding this comment.
How about using validation.DNS1123SubdomainMaxLength in k8s.io/apimachinery/pkg/util/validation instead of the magic number?
internal/hrq/utils/scopedhrq.go
Outdated
| metadata.SetLabel(rq, hrqNameLabel, hrqName) | ||
| } | ||
|
|
||
| func truncate(s string, n int) string { |
Member
There was a problem hiding this comment.
n should be positive numbers to avoid panic. Using uint or adding validation?
…23SubdomainMaxLength for improved name length handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was an issue where the names of scoped RQs created from scoped HRQs could conflict. This PR fixes that problem.
Problem
In the previous implementation, the name of a scoped RQ was just a prefixed version of the scoped HRQ name. As a result, if a parent namespace and a child namespace had scoped HRQs with the same name, it would try to create RQs with the same name in the child namespace and fail.
Solution
This PR changes the RQ naming to include the namespace name and an MD5 hash of
hrqNamespace/hrqName. However, since this can make the name exceed the length limit, the name is truncated appropriately when it's too long.