Skip to content

#54: Fixes issue with phpcs using wrong autoloader #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

#54: Fixes issue with phpcs using wrong autoloader #70

wants to merge 1 commit into from

Conversation

michael-wojcik
Copy link

Patch to fix issue mentioned in #54

@michael-wojcik michael-wojcik mentioned this pull request Dec 5, 2019
Closed
danepowell
danepowell approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@danepowell danepowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! I can confirm that this fixes the problem and makes sense as a fix. It's still not 100% deterministic, but it's way less likely to cause conflicts than the old path.

@klausi
Copy link
Collaborator

klausi commented Dec 7, 2019

Thanks, used a bit of a different approach in #72

@klausi klausi closed this Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danepowell danepowell danepowell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michael-wojcik @klausi @danepowell