Allow NS/MX records to have hostnames with pfSense-pkg-bind9 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this pull request can be accepted you must first sign a CLA as described at https://www.pfsense.org/about-pfsense/#cla. Please read for more details. |
rbgarga
requested changes
Feb 22, 2017
| @@ -513,7 +510,10 @@ EOD; | |||
| } | |||
| } | |||
| for ($y = 0; $y < sizeof($zone['row']); $y++) { | |||
| $hostname = (preg_match("/(MX|NS)/", $zone['row'][$y]['hosttype']) ? "@" : $zone['row'][$y]['hostname']); | |||
| $hostname = $zone['row'][$y]['hostname']; | |||
| if (preg_match("/(MX|NS)/", $zone['row'][$y]['hosttype']) && trim($hostname) == false) { | |||
There was a problem hiding this comment.
In which case you expect trim($hostname) to return false?
There was a problem hiding this comment.
The old code checked if the hosttype was MX or NS, then it would always substitute "@" for the hostname. The trim($hostname) check is so that this substitution only occurs if hostname was left empty, which makes this change backward compatible. Otherwise, the hostname provided by the user is kept.
There was a problem hiding this comment.
According to trim docs it will never return false, only trimmed string.
There was a problem hiding this comment.
"==" is not a strict operator in PHP, so the string will be converted to a boolean value for the comparison, and any non-empty string converts to "true," otherwise "false" for an empty string. So, it is the case that ('' == false) is true, however, I see the prevailing style in this particular script is to test equality to an empty string, so I will change it.
geekmug
force-pushed
the
bind-allow-ns-hostnames
branch
2 times, most recently
from
1e47a5c
to
b431c74
Compare
geekmug
force-pushed
the
bind-allow-ns-hostnames
branch
from
b431c74
to
e6a1a71
Compare
rbgarga
approved these changes
Jul 13, 2017
jim-p
approved these changes
Jul 28, 2017
netgate-git-updates
pushed a commit
that referenced
this pull request
Jul 28, 2017
netgate-git-updates
pushed a commit
that referenced
this pull request
Jul 5, 2022
Changes since 0.3.0: We reached v1.0.0 - fix!: Replace limit flag with paginate by @ankitpokhrel in #359 - fix!: Append components on edit instead of overriding by @ankitpokhrel in #368 - feat!: Append label to an issue, show labels at issue list view by @stchar in #300 - refactor!: Move boards and project list to subcommand by @ankitpokhrel in #314 - feat: Support custom fields on issue create by @ankitpokhrel in #319 - feat: Add support to read from .netrc by @adolsalamanca in #329 - feat: Add support for OS keyrings/-chains by @boyvanamstel in #348 - feat: Support auth with personal access tokens by @marek-veber / @ankitpokhrel in #327 - feat: Allow to set fixVersions on issue creation by @ankitpokhrel in #276 - feat: Allow insecure TLS by @ankitpokhrel in #305 - feat: Add --no-browser option to open cmd by @ankitpokhrel in #308 - feat: Add search option for boards on jira init by @ankitpokhrel in #322 - feat: Add issues unlink command by @sushilkg in #347 - feat: Support refresh for issues list by @GZLiew in #325 - feat: Ability to delete issue by @ankitpokhrel in #336 - feat: Allow to set custom fields on epic create by @ankitpokhrel in #364 - feat: Allow to edit release-info/fixVersions by @ankitpokhrel in #365 - feat: Allow removing labels on edit by @ankitpokhrel in #371 - feat: Support creating issues with custom subtask type by @danobi in #372 - feat: Allow removing component on edit by @ankitpokhrel in #374 - feat: Allow removing fixVersions on edit by @ankitpokhrel in #376 - feat: Support custom fields on issue edit by @ankitpokhrel in #377 - feat: Jira init non-interactive by @ankitpokhrel in #381 - feat: Show subtasks in issue view by @ankitpokhrel in #382 - feat: Allow project filter in raw jql by @ankitpokhrel in #395 - fix: Makefile compatiblity with Make 3.81 by @danmichaelo in #252 - fix: Config generation issue by @ankitpokhrel in #275 - fix(cfg): Strip trailing slash on server name by @ankitpokhrel in #295 - fix: Jira client should respect timeout opt by @ankitpokhrel in #304 - fix: Respect GLAMOUR_STYLE env on issue view by @ankitpokhrel in #317 - fix: Get subtask handle from config by @ankitpokhrel in #296 - fix: Jira wiki parser by @ankitpokhrel in #326 - fix: Display correctly columns in list sprint command help by @adolsalamanca in #320 - fix: Panic on empty sub-list by @ankitpokhrel in #330 - fix: Issue with assigning user by @ankitpokhrel in #321 - fix: OOM bug on issue view by @ankitpokhrel in #350 - fix: Assign parent key as is on edit by @ankitpokhrel in #351 - fix: Add additional check for total boards returned by @ankitpokhrel in #360 - fix: Issue with query param in user assignment by @ankitpokhrel in #380 - fix: Subtask clone by @ankitpokhrel in #383 - fix: editing issue with custom field in non interactive mode by @DrudgeRajen in #391 - dep: Upgrade charmbracelet/glamour to 0.5.0 by @ankitpokhrel in #309 - dep: Upgrade rivo/tview to latest by @ankitpokhrel in #310 - dep: Upgrade outdated packages by @ankitpokhrel in #311 - dep: Upgrade cobra to 1.4.0 by @ankitpokhrel in #373 - Use md ext for tmp file to trigger vim syntax by @ElementalWarrior in #318 Full Changelog: ankitpokhrel/jira-cli@v0.3.0...v1.0.0
netgate-git-updates
pushed a commit
that referenced
this pull request
Mar 31, 2023
ChangeLog: https://github.com/cbsd/reggae/releases/tag/0.3.5 * Be more aggressive in destroying epair by @mekanix in #304 * Handle case when hostname is empty by @mekanix in #305 PR: 270548 Reported by: meka@tilda.center (maintainer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the BIND package would blank out the hostname field and always use "@" for either MX or NS records. However, this is an arbitrary limitation. If you want to delegate a sub-domain, then you need to be able to provide a NS record with a hostname. Additionally, providing MX records for hosts is a valid record as well.
This patch continues to allow a blank hostname field (automatically replacing with "@"), so this should be backward compatible for existing users.