Bugfix for Bug #7278 Suricata Service - Advanced Configuration Pass-Through not working #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please check it out @bmeeks8 ? |
|
I am OK with this fix. I had this on my TODO list, so thank you to @securitym0nkey for submitting the fix. Bill |
|
@securitym0nkey please bump PORTVERSION or PORTREVISION on suricata/Makefile to make sure a new package is going to be created |
|
Sorry @securitym0nkey but I missed it and a new change on Makefile happened in this meantime. Can you please rebase your fork and bump PORTREVISION again? I'll merge it as soon as you do it |
Also fixing a form render error: After saving the "Advanced Configuration Pass-Through" is showing base64 encoded text.
securitym0nkey
force-pushed
the
Bug-7278-Advanced_Configuration_Pass-Through_not_working
branch
from
d8dda93
to
178c99b
Compare
|
@rbgarga no problem. rebase + PORTREVISION dump done. |
rbgarga
reviewed
Jul 13, 2017
security/suricata/Makefile
Outdated
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| PORTNAME= suricata | |||
| PORTVERSION= 3.2.2 | |||
| PORTREVISION= 1 | |||
There was a problem hiding this comment.
You should bump PORTREVISION of security/pfSense-pkg-suricata instead of security/suricata. Can you change this please?
There was a problem hiding this comment.
edit the wrong file. to late in my timezone ;) will fix it.
securitym0nkey
force-pushed
the
Bug-7278-Advanced_Configuration_Pass-Through_not_working
branch
from
178c99b
to
5659c24
Compare
|
@rbgarga this should be ok now, right? sorry for the inconvenience handling my stupid mistake |
|
FWIW I patched this in to my system and it is working well. |
netgate-git-updates
pushed a commit
that referenced
this pull request
Jul 26, 2017
…ration_Pass-Through_not_working
netgate-git-updates
pushed a commit
that referenced
this pull request
Oct 3, 2020
* MooseFS 3.0.114-1 (2020-07-27) - (mount) fixed trunacting files open with O_APPEND flag (bug itntr. in 3.0.113, issue #368) - (cs) added disk rebalance when all designated source disks are already empty (issue #364) - (mount) added additional info to '.params' file (versions of mfs,libfuse itp.) - (master+cs) added check against EACCES after lockf (according to Linux man - such stupid error can be returned here - issue #369) - (master) fixed access checks in snapshot - (cgi+cli) removed using supervisor (only available in PRO version) - (cs) fixed deadlock condition on mutexes 'folderlock' and 'hashlock' (exists since 3.0.110) - (tools) fixed oveflow protection in number parsing function - (cs) fixed reporting to master duplicates with newer version - (cs) changed job queue policy (some tasks are not limited now) - (master) fixed reaction to status NOTDONE received from chunkservers - (master) fixed syncing and closing negative file descriptor in bgsaver - (mount+master) fixed handling keepcache and direct flags (related to issue #374) - (cgi) changed time format (issue #197) - (cs) added logging info when '.chunkdb' is not written to disk - (master) fixed alphabetical order of commands detected in changelog - (cs) changed queue limit to max workers (limited dynamically) - (cs) fixed automatic chunkserver removal in master - (master) added meta version increment in chunks_set_version - (cs) added error detection during writing '.chunkdb' - (all) added build id to 'what' strings - (nbd+cgiserv) added chdir("/") PR: 250060 Submitted by: MooseFS FreeBSD Team <freebsd@moosefs.pro> (maintainer)
netgate-git-updates
pushed a commit
that referenced
this pull request
Jul 5, 2022
Changes since 0.3.0: We reached v1.0.0 - fix!: Replace limit flag with paginate by @ankitpokhrel in #359 - fix!: Append components on edit instead of overriding by @ankitpokhrel in #368 - feat!: Append label to an issue, show labels at issue list view by @stchar in #300 - refactor!: Move boards and project list to subcommand by @ankitpokhrel in #314 - feat: Support custom fields on issue create by @ankitpokhrel in #319 - feat: Add support to read from .netrc by @adolsalamanca in #329 - feat: Add support for OS keyrings/-chains by @boyvanamstel in #348 - feat: Support auth with personal access tokens by @marek-veber / @ankitpokhrel in #327 - feat: Allow to set fixVersions on issue creation by @ankitpokhrel in #276 - feat: Allow insecure TLS by @ankitpokhrel in #305 - feat: Add --no-browser option to open cmd by @ankitpokhrel in #308 - feat: Add search option for boards on jira init by @ankitpokhrel in #322 - feat: Add issues unlink command by @sushilkg in #347 - feat: Support refresh for issues list by @GZLiew in #325 - feat: Ability to delete issue by @ankitpokhrel in #336 - feat: Allow to set custom fields on epic create by @ankitpokhrel in #364 - feat: Allow to edit release-info/fixVersions by @ankitpokhrel in #365 - feat: Allow removing labels on edit by @ankitpokhrel in #371 - feat: Support creating issues with custom subtask type by @danobi in #372 - feat: Allow removing component on edit by @ankitpokhrel in #374 - feat: Allow removing fixVersions on edit by @ankitpokhrel in #376 - feat: Support custom fields on issue edit by @ankitpokhrel in #377 - feat: Jira init non-interactive by @ankitpokhrel in #381 - feat: Show subtasks in issue view by @ankitpokhrel in #382 - feat: Allow project filter in raw jql by @ankitpokhrel in #395 - fix: Makefile compatiblity with Make 3.81 by @danmichaelo in #252 - fix: Config generation issue by @ankitpokhrel in #275 - fix(cfg): Strip trailing slash on server name by @ankitpokhrel in #295 - fix: Jira client should respect timeout opt by @ankitpokhrel in #304 - fix: Respect GLAMOUR_STYLE env on issue view by @ankitpokhrel in #317 - fix: Get subtask handle from config by @ankitpokhrel in #296 - fix: Jira wiki parser by @ankitpokhrel in #326 - fix: Display correctly columns in list sprint command help by @adolsalamanca in #320 - fix: Panic on empty sub-list by @ankitpokhrel in #330 - fix: Issue with assigning user by @ankitpokhrel in #321 - fix: OOM bug on issue view by @ankitpokhrel in #350 - fix: Assign parent key as is on edit by @ankitpokhrel in #351 - fix: Add additional check for total boards returned by @ankitpokhrel in #360 - fix: Issue with query param in user assignment by @ankitpokhrel in #380 - fix: Subtask clone by @ankitpokhrel in #383 - fix: editing issue with custom field in non interactive mode by @DrudgeRajen in #391 - dep: Upgrade charmbracelet/glamour to 0.5.0 by @ankitpokhrel in #309 - dep: Upgrade rivo/tview to latest by @ankitpokhrel in #310 - dep: Upgrade outdated packages by @ankitpokhrel in #311 - dep: Upgrade cobra to 1.4.0 by @ankitpokhrel in #373 - Use md ext for tmp file to trigger vim syntax by @ElementalWarrior in #318 Full Changelog: ankitpokhrel/jira-cli@v0.3.0...v1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug 7278 Suricata Service - Advanced Configuration Pass-Through not working
Also fixing a form render error: After saving the "Advanced Configuration Pass-Through" is showing base64 encoded text.