chore: update demo app versions to snapshot #236
Conversation
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
View your CI Pipeline Execution ↗ for commit c6c0dc8
☁️ Nx Cloud last updated this comment at |
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-236.pgflow.pages.dev 📝 Details:
_Last updated: _ |
🔍 Preview Deployment: Playground✅ Deployment successful! 🔗 Preview URL: https://pr-236--pgflow-demo.netlify.app 📝 Details:
_Last updated: _ |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| -- Modify "steps" table | ||
| ALTER TABLE "pgflow"."steps" ADD CONSTRAINT "opt_start_delay_is_nonnegative" CHECK ((opt_start_delay IS NULL) OR (opt_start_delay >= 0)), ADD COLUMN "opt_start_delay" integer NULL; |
There was a problem hiding this comment.
The migration adds opt_start_delay and a non‑negative check in one ALTER TABLE, but the constraint is declared before the column exists (ALTER TABLE ... ADD CONSTRAINT …, ADD COLUMN …). PostgreSQL executes clauses left‑to‑right, so this statement fails because the constraint references a non‑existent column. The migration will halt on apply and none of the later changes run until the order is corrected.
Useful? React with 👍 / 👎.
| -- Modify "step_task_record" composite type | ||
| ALTER TYPE "pgflow"."step_task_record" ADD ATTRIBUTE "task_index" integer; |
There was a problem hiding this comment.
The type pgflow.step_task_record now includes a task_index attribute, but helper functions such as pgflow.poll_for_tasks (defined in earlier migrations and unchanged here) still return only flow_slug, run_id, step_slug, input and msg_id. After this migration, calling poll_for_tasks will raise “structure of query does not match function result type” because the SELECT no longer matches the six‑column composite. Any worker relying on the function will fail to fetch tasks until the function is recreated to emit task_index as well.
Useful? React with 👍 / 👎.
Merge activity
|
No description provided.