Add e2e test for async function compilation (issue #123) #238
Conversation
…r issue #123 - Introduced a new flow example demonstrating async function hang scenario - Updated project configuration to include a new end-to-end test for async hang issue - Added a script to reproduce and verify if compilation hangs on flows with async functions - Enhanced CI pipeline to run the new test, aiding in regression detection for issue #123
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
jumski
changed the title
Merge activity
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected -t lint typecheck test --parallel -... |
❌ Failed | 17s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-10-08 08:52:44 UTC
Fixes #123 ### Summary Adds an e2e test to reproduce the async function compilation hang reported in issue #123. However, **the issue cannot be reproduced** in the current codebase - compilation with async function handlers co mpletes successfully. ### Issue Description @cpursley reported that compilation would hang when using async functions in flow step handlers. After removing the `async` keywords, compilation worked. The problematic pattern was: ```typescript .step( { slug: 'process_company_logo' }, async (input) => await processCompanyLogoTask({ ... }) ) ``` ### Changes Made - **Test Flow**: Added `pkgs/cli/examples/async-function-hang.ts` - reproduces the exact pattern from the issue with dummy async tasks - **E2E Test Script**: Added `pkgs/cli/scripts/test-async-hang-issue-123` - automated test with 30s timeout to detect hangs - **Nx Target**: Added `test:e2e:async-hang-issue-123` to `pkgs/cli/project.json` ### Test Results The test passes successfully, indicating: 1. Async functions in handlers compile without hanging 2. The compilation completes in under 30 seconds 3. Migration files are generated correctly ### Possible Explanations The issue may have been: - Fixed by other changes in the codebase - Specific to the user's environment or the actual task imports used - Related to network issues when Deno was fetching dependencies The test now provides regression protection if this issue resurfaces.
Fixes #123
Summary
Adds an e2e test to reproduce the async function compilation hang reported in issue #123. However, the issue cannot be reproduced in the current codebase - compilation with async function handlers co
mpletes successfully.
Issue Description
@cpursley reported that compilation would hang when using async functions in flow step handlers. After removing the
asynckeywords, compilation worked. The problematic pattern was:Changes Made
pkgs/cli/examples/async-function-hang.ts- reproduces the exact pattern from the issue with dummy async taskspkgs/cli/scripts/test-async-hang-issue-123- automated test with 30s timeout to detect hangstest:e2e:async-hang-issue-123topkgs/cli/project.jsonTest Results
The test passes successfully, indicating:
Possible Explanations
The issue may have been:
The test now provides regression protection if this issue resurfaces.