refactor: use realpath and consistent cwd in supabase-start-locked.sh #368
Conversation
jumski
commented
Nov 15, 2025
jumski
commented
- Replace cd && pwd with realpath for cleaner code
- Standardize all project.json to use cwd: {projectRoot}
- Remove unnecessary cd {projectRoot} commands
- Use consistent ../../scripts/supabase-start-locked.sh . pattern
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
View your CI Pipeline Execution ↗ for commit b3b448c
☁️ Nx Cloud last updated this comment at |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Normalize to absolute path to ensure consistent lock naming | ||
| # This prevents "./pkgs/core" and "pkgs/core" from creating different locks | ||
| PROJECT_DIR_ABS=$(cd "$PROJECT_DIR" && pwd) | ||
| PROJECT_DIR_ABS=$(realpath "$PROJECT_DIR") |
There was a problem hiding this comment.
Replacing cd "$PROJECT_DIR" && pwd with realpath "$PROJECT_DIR" introduces a dependency that is not installed by default on macOS and some BSD systems. Developers running Supabase tasks on those platforms will hit realpath: command not found and the script exits before starting Supabase. Consider using the previous cd … && pwd approach or adding a fallback so the script remains portable.
Useful? React with 👍 / 👎.
jumski
force-pushed
the
11-15-refactor_use_realpath_and_consistent_cwd_in_supabase-start-locked.sh
branch
5 times, most recently
from
c52d183 to
9ed1717
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
jumski
force-pushed
the
11-15-refactor_use_realpath_and_consistent_cwd_in_supabase-start-locked.sh
branch
from
9ed1717 to
805fac5
Compare
- Replace cd && pwd with realpath for cleaner code
- Standardize all project.json to use cwd: {projectRoot}
- Remove unnecessary cd {projectRoot} commands
- Use consistent ../../scripts/supabase-start-locked.sh . pattern
jumski
force-pushed
the
11-15-refactor_use_realpath_and_consistent_cwd_in_supabase-start-locked.sh
branch
from
805fac5 to
b3b448c
Compare
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-368.pgflow.pages.dev 📝 Details:
_Last updated: _ |
Merge activity
|
…#368) - Replace cd && pwd with realpath for cleaner code - Standardize all project.json to use cwd: {projectRoot} - Remove unnecessary cd {projectRoot} commands - Use consistent ../../scripts/supabase-start-locked.sh . pattern
