Hypercorn server websocket consider close code as 1006 upon client side close

[wenleix]

Hi,

I note Hypercorn server websocket consider will close code as 1006, albeit client side close with 1000 code sent:

1. Start hypercorn server
2. Start client and establish connection
3. Hypercorn server is waiting for .receive_text()
4. Client close connection with 1000 closed code
5. Hypercorn receives WebSocketDisconnect exception with 1006 code

Here is a demonstration to reproduce it: https://github.com/wenleix/hypercorn-ws2

[jannschu]

I also ran into this. I looked into the code of ws_stream.py and the issue seems to be that during handling of the CloseConnection event from the client in _handle_events the connection state is not updated. So when the stream is subsequently closed the corresponding event, handled in handle, is interpreted as "loss of socket" leading to 1006.

In fact, only 1000 or 1006 are possible values with the current implementation which is not correct. The ASGI specifies this value to be the code sent by the server/client when closing the connection, if available.