Sort by Track

[alex-phillips]

This adds an optional subSortKey argument to the sort function so that we can perform a subsort on the data structure to allow for sorting by tracks when we sort by album.

This address issue #240

[phanan]

Thanks, but your PR contains a number of problems:

• Code style (as specified by CI)
• Uses var instead of let or const
• Contains logging code
• Addesses multiple functionalities in one PR
• Commits not squashed
• Most importantly, missing functionality: If track is introduced, shouldn't it be editable?

[phanan]

My bad – didn't notice you submitted another PR for the extra functionality. Do you mind fixing the other issues listed above though? Thanks!

[alex-phillips]

@phanan fixed all of the above including added support for editing the track in the modal

[phanan]

That's fast! Please give me some time to validate the changes.

[phanan]

Hmm… Actually, this PR breaks the tests.

[alex-phillips]

No problem. Forgot to consider the new column track in the tests. Should be all fixed now.

There might be a better way to implement the sub sort key - maybe a recursive function so that you can pass an arbitrary number of subsort keys and it would traverse all of them? I'm still fairly new to Vue JS so not sure how to call that sort function inside of itself since it is a Vue.filter definition.

[phanan]

Come to think of it, should we implement this sub-sort feature though? I'd suggest to keep it as simple as an extra standalone Track # column, à la iTunes:

Granted, this column isn't even helpful in a "mixed" screen, but shouldn't the users only use it for Single Album view, where it's meant to be used?

If you chose to go this route, please take note of the responsive views.

[alex-phillips]

I'm a little confused. As far as I can tell, iTunes does sort your library based on album groupings as well as track number. Ex: if you view your entire library and sort by the "Artist" column, the artists are group but sub-sorted alphabetically by their album names and the albums are sub-sorted by the tracks so that the album stays in the proper order. We could add a column like you said, but I think sorting on track number is extremely important.

As I mentioned above, this should probably be taken a step further where we can pass in an arbitrary number of sub sort keys so that you can have it perform like iTunes does (sort by Artist name, then album, and then by track within that album).

I'd be happy to tackle this arbitrary number of sorts, but as I said I'm not as familiar with Vue.js quite yet. Not sure how to reference the sort function within itself.

[phanan]

I've just checked iTunes again – the behavior is exactly like what you said. Man I really need some coffee.

[alex-phillips]

Haha, no worries. I'm going to see if I can tackle that advanced subsorting I mentioned. Feel free to merge this if you want, but I may open another PR to implement further sorting.

[phanan]

❤️

[phanan]

Please use php artisan make:migration for any database schema changes instead of modifying the original files.