Switch from mixed return to Exception

Author: MacFJA

src/Filename.php

@@ -133,13 +133,19 @@ public function delete() {
     /**
      * @param string $newName
      *
-     * @return Filename|false
+     * @return Filename
+     * @throws FilenameException
      */
     public function rename($newName) {
         $newNameFile = $this->getDirectory()->file($newName);
         $result = @rename($this->asString(), $newNameFile->asString());
         if ($result === false) {
-            return false;
+            $lastError = error_get_last();
+            $nativeError = new \RuntimeException(
+                sprintf('%s (line %d): %s', $lastError['file'], $lastError['line'], $lastError['message']),
+                $lastError['type']
+            );
+            throw new FilenameException('Unable to rename the file.', 0, $nativeError);
         }
         return $newNameFile;
     }

tests/FilenameTest.php

@@ -106,6 +106,8 @@ public function testFailedRename() {
 
         $this->assertFalse($filename->exists());
         $this->assertTrue($filename->isWritable());
+        $this->expectException(FilenameException::class);
+        $this->expectExceptionMessage('Unable to rename the file.');
 
         try {
             touch($filename->asString());
@@ -116,8 +118,7 @@ public function testFailedRename() {
             $mode = fileperms($filename->getDirectory());
             chmod($filename->getDirectory(), 0000);
 
-            $renamed = $filename->rename('bar2.txt');
-            $this->assertFalse($renamed);
+            $filename->rename('bar2.txt');
         } finally {
             if (isset($mode)) {
                 chmod($filename->getDirectory(), $mode);