Skip to content

Conversation

@guillep
Copy link
Member

@guillep guillep commented Nov 2, 2022

We are losing PIC and monomorphic type information on each full GC.
This PR tries to avoid unlinking on each GC to see if there is a side effect.

@privat
Copy link
Contributor

privat commented Nov 4, 2022

Nothing seems broken, but cache invalidation is one of the two hardest things in computer science. :)

The commit that introduced this mandatory callsite flush (among so many things) is 81fc34e.

@PalumboN
Copy link
Collaborator

There are two (possible) related failing tests:

VM Unit Tests / testOnStackReplacementForLongRunningVectorAddMethod(#ISA->#IA32 #wordSize->4) – MacOSX64.VMMakerTests.JitTests.VMJitMethodTest
<1s
VM Unit Tests / testMemoryAccessExceptionHandledTimeoutIsRespected(#ISA->#aarch64 #wordSize->8) – MacOSX64.VMMakerTests.JitTests.VMMachineSimulatorTest
1m 6s

The commit that introduces the unlink-send behaviour is what Jean said. And the call from preGCAction: appeared here 7c0d0ab#diff-715172f5f9bc44477ac2dc857665367d6e38210cc77747ad5ea4da441814ca4a

@tesonep tesonep changed the base branch from pharoX to pharo-10 December 16, 2022 09:27
@guillep guillep changed the base branch from pharo-10 to pharo-12 May 12, 2023 12:45
@guillep
Copy link
Member Author

guillep commented May 12, 2023

Tests are green

@guillep guillep merged commit 357fcad into pharo-project:pharo-12 May 12, 2023
@guillep guillep deleted the cleanup/unlinking branch May 12, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants