Merge pull request #1907 from pharo-spec/dev-3.0

estebanlm · web-flow · commit ba04da5f6fad · 2026-05-07T10:55:41.000+02:00
fix a couple of errors I introduced when fixing FTTableMorph double click
diff --git a/src/Spec2-Backend-Tests/SpMorphicBackendForTest.class.st b/src/Spec2-Backend-Tests/SpMorphicBackendForTest.class.st
@@ -96,13 +96,23 @@ SpMorphicBackendForTest >> denyHasHeader: anAdapter [
 
 { #category : 'simulating' }
 SpMorphicBackendForTest >> doubleClickFirstRowAndColumn: anAdapter [ 
+	| event position |
 
 	self waitUntilUIRedrawed.
 
-	anAdapter widget doubleClick: (MouseButtonEvent new
-		setPosition: anAdapter widget submorphs first submorphs first bounds center;
-		yourself).
-
+	position := anAdapter widget submorphs first submorphs first bounds center.
+	event := MouseButtonEvent new
+		setType: #mouseDown
+			position: position 
+			buttons: 0
+			hand: HandMorph new; 
+		yourself.
+		
+	"simulating double click means send one mouseDown: and one double-click because 
+	 when doing a real one, we always receive the first click then the one we want."
+	anAdapter widget 
+		mouseDown: event;
+		doubleClick: event
 ]
 
 { #category : 'initialization' }
diff --git a/src/Spec2-Commander2/CmUICommand.extension.st b/src/Spec2-Commander2/CmUICommand.extension.st
@@ -9,7 +9,7 @@ CmUICommand >> id [
 			self shortcutKey
 				ifNotNil: [ 'shortcut ', (KMShortcutPrinter toString: self shortcutKey) ]
 				ifNil: [ 'unknown' ] ].
-		parts := name substrings: ' :'.
+		parts := name substrings: ' :()'.
 		stream << parts first asLowercase.
 		parts allButFirstDo: [ :each | stream << each capitalized ] ]
 ]
diff --git a/src/Spec2-Commander2/SpCommand.class.st b/src/Spec2-Commander2/SpCommand.class.st
@@ -160,12 +160,6 @@ SpCommand >> isEnabled [
 	^ self canBeExecuted
 ]
 
-{ #category : 'testing' }
-SpCommand >> isVisible [
-
-	^ self canBeExecuted 
-]
-
 { #category : 'accessing' }
 SpCommand >> presenter [
 	^ presenter

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ CmUICommand >> id [`
`9`	`9`	`self shortcutKey`
`10`	`10`	`ifNotNil: [ 'shortcut ', (KMShortcutPrinter toString: self shortcutKey) ]`
`11`	`11`	`ifNil: [ 'unknown' ] ].`
`12`		`- parts := name substrings: ' :'.`
	`12`	`+ parts := name substrings: ' :()'.`
`13`	`13`	`stream << parts first asLowercase.`
`14`	`14`	`parts allButFirstDo: [ :each \| stream << each capitalized ] ]`
`15`	`15`	`]`