-
Notifications
You must be signed in to change notification settings - Fork 53
Description
Describe the bug
I'll prefix this with I'm a bit of a newcomer here and admittedly not even close to an expert on anything frontend-related, so I apologize if this might be a non-issue 🙂
The frontend container build is currently not reproducible with just the code + Dockerfile, you have to yarn install without --production/--frozen-lockfile outside or in a separate container before running the actual build (as done in the actions workflow) - for example the autoprefixer package seems to be missing from the dependencies on the production side.
This could from my understanding, depending on the OS the image is built on, cause a bunch of discrepancies in how the application is built over time and between machines.
To Reproduce
Steps to reproduce the behavior:
- Clone the repository
- Go to the frontend repo
- Run
docker build -t phase-local/frontend:latest . - Receive error
Expected behavior
Reproducible container builds based on the checked-in code and Dockerfile no matter the underlying OS and NodeJS version/package manager outside the container
Also
Line 31 in e7963af
| RUN cp -R node_modules /tmp/node_modules |
Screenshots
Platform you are having the issue on:
Additional context
Tried with both main, v2.52.0